fix: detect identifiers in comments using regex, not strings.Fields - #62
Open
p4l1ly wants to merge 2 commits into
Open
fix: detect identifiers in comments using regex, not strings.Fields#62p4l1ly wants to merge 2 commits into
p4l1ly wants to merge 2 commits into
Conversation
p4l1ly
force-pushed
the
comment_lits
branch
from
September 25, 2020 08:22
72164b8 to
a9a6a04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With substitution "SomeThing=int", the comment
// foo=SomeThing,OtherThingwas being changed to
// foo=Int,OtherThing.The capital
Iis a problem. This fix resolves the problem. I've used regex directly instead ofgo/parserbecause it would fail inside comments (didn't try).