fix(agent): continue truncated model turns - #185
Merged
Conversation
Treat provider output-length termination as nonterminal durable state. Validate finish reasons at the agent boundary and complete only after a semantic stop.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lengthfinish reasons as nonterminal model turns.stopas tool-free semantic completion.Root cause
The production Pomodoro retry recovered its Daytona runtime correctly, but Claude reached its per-response output limit while forming the next operation. The Workflow used only the absence of parsed tool calls as its completion condition, so it finalized that truncated turn and exposed the sandbox readiness page.
Architecture
The Mastra adapter validates the six AI SDK finish reasons. Cloudflare Workflow owns the policy: tool calls execute durably;
lengthappends a non-visible continuation message and starts another checkpointed model turn; onlystopcompletes a tool-free run. This keeps semantic completion in charge without adding a step, token, duration, or cost ceiling.Decisions
Production evidence
019fe1b3-af54-7a69-bd1d-0cd940842e41completed after model turn 5 returnedfinishReason: "length"with no tool call.Verification
pnpm lintpnpm typecheckpnpm turbo build --forcepnpm deadcodepnpm architecture:checkpnpm turbo skills:buildHow to review
packages/agent-core/src/mastra/durable-agent-step.ts.apps/agent-worker/src/durable-objects/agent-run-workflow.ts.agent-run-workflow-runtime.tsand the README contract matches the implementation.