fix(auth): make social login use one redirect navigation - #180
Merged
Conversation
Replace fragile popup callbacks with one full-page Clerk navigation and restore same-origin opener isolation. This prevents remote popup renderer failures from crashing the signed-out application tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cross-Origin-Opener-Policy: same-originnow that authentication does not need an opener relationship.Root cause
Production Google OAuth reached Clerk and created the session, but the popup callback intermittently failed while loading a remote
@clerk/uichunk. The popup then had to reconcile the newly authenticated identity into the already-rendered anonymous application tree, producing the generic client-side exception page.Architecture
OAuth now performs one authoritative navigation:
Cheatcode sign-in -> Google -> Clerk callback -> requested Cheatcode pathThe installed
@clerk/uiversion remains pinned throughClerkProvider; only the transport changes.Decisions made
same-originsame-origin-allow-popupsui={ui}Verification
pnpm lintpnpm typecheckpnpm turbo build --forcepnpm deadcodepnpm architecture:checkpnpm turbo skills:buildScope
No database, migration, environment, API, or worker topology changes.