fix(skills): persist creator output directly - #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill_createthe request-scoped durable save boundary in Skill Creator modeTracking
Direct production hardening requested in this workstream; no Linear issue or standalone plan document exists for this focused correction.
What's Included
Direct skill persistence
data-skill-createdUI event only after persistence completesLegacy removal
data-skill-proposedparts with migration0076Package fidelity
SKILL.mdmetadata while retaining references, TypeScript entrypoints, schemas, scripts, and assetsDecisions Made
skill_createcallEdge Cases Handled
SKILL.mdHow to Review
packages/agent-core/src/mastra/tools/skill-tools.tsandagent-run-user-skills.tsfor the save path.user-skill-packages.tsfor full-package collection.0076for legacy cleanup.Verification
pnpm turbo typecheckpnpm turbo lintpnpm turbo buildpnpm architecture:checkpnpm deadcodeRelease Gate Companionwithout approval.cheatcode/skills/release-gate-companion/references/checklist.mdwas present