Skip to content

fix(web): stabilize image preview loading #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamjr15 merged 1 commit into from
Aug 4, 2026
Merged

fix(web): stabilize image preview loading #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions apps/web/src/components/chat/message-deliverables.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,18 +354,27 @@ function useLazyImagePreview(
getToken: () => Promise<null | string>,
): ImagePreview {
const hostRef = useRef<HTMLDivElement | null>(null);
const getTokenRef = useRef(getToken);
const isNearViewport = useNearViewport(hostRef);
const [preview, setPreview] = useState<Omit<ImagePreview, "hostRef">>({
message: null,
status: "idle",
url: null,
});
useEffect(() => {
getTokenRef.current = getToken;
}, [getToken]);
useEffect(() => {
if (!isNearViewport) return;
const controller = new AbortController();
let objectUrl: string | null = null;
setPreview({ message: null, status: "loading", url: null });
void loadOutputImagePreview(getToken, data.outputId, data.sizeBytes, controller.signal)
void loadOutputImagePreview(
() => getTokenRef.current(),
data.outputId,
data.sizeBytes,
controller.signal,
)
.then((blob) => {
objectUrl = URL.createObjectURL(blob);
setPreview({ message: null, status: "ready", url: objectUrl });
Expand All @@ -382,7 +391,7 @@ function useLazyImagePreview(
controller.abort();
if (objectUrl) URL.revokeObjectURL(objectUrl);
};
}, [data.outputId, data.sizeBytes, getToken, isNearViewport]);
}, [data.outputId, data.sizeBytes, isNearViewport]);
return { ...preview, hostRef };
}

Expand Down
9 changes: 7 additions & 2 deletions apps/web/src/lib/api/outputs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
} from "@/lib/api/authorized-fetch";

const OUTPUT_IMAGE_PREVIEW_MAX_BYTES = 20 * 1024 * 1024;
const OUTPUT_IMAGE_PREVIEW_TIMEOUT_MS = 30_000;

export async function createOutputDownloadUrl(
getToken: () => Promise<null | string>,
Expand All @@ -39,10 +40,14 @@ export async function loadOutputImagePreview(
if (sizeBytes <= 0 || sizeBytes > OUTPUT_IMAGE_PREVIEW_MAX_BYTES) {
throw new Error("This image is too large to preview here. Download it to view the original.");
}
const capability = await createOutputDownloadUrl(getToken, outputId, signal);
const requestSignal = AbortSignal.any([
signal,
AbortSignal.timeout(OUTPUT_IMAGE_PREVIEW_TIMEOUT_MS),
]);
const capability = await createOutputDownloadUrl(getToken, outputId, requestSignal);
const response = await fetch(capability.downloadUrl, {
referrerPolicy: "no-referrer",
signal,
signal: requestSignal,
});
if (!response.ok) {
throw new Error(`Image preview returned HTTP ${response.status}`);
Expand Down