fix(db): scope artifact upload row lock - #146
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2_agent_runsrow while validating artifact-upload ownershipWhy
PostgreSQL applies an unqualified
FOR UPDATEto every relation in a joined query. The agent role intentionally cannot update projects, so generated media reached persistence and then failed before its upload intent could be committed.FOR UPDATE OF v2_agent_runsmatches the intended concurrency boundary and the clean baseline ACLs.Verification
pnpm exec biome check packages/db/src/artifact-upload-intents.tspnpm turbo lintpnpm turbo typecheck --filter=@cheatcode/db --filter=@cheatcode/agent-workerpnpm turbo build --filter=@cheatcode/agent-workerpnpm db:migrate -- --dry-run