fix(web): allow integration logos through CSP - #117
Merged
Conversation
Authorize the exact Composio image origin and remove the redundant Next optimizer allowlist. Keep browser takeover on the owned preview proxy instead of widening CSP to Daytona domains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
img-srcpolicy so skill cards render their brand marksremotePatternsentry because these SVGs useunoptimizedand bypass the optimizerframe-srcArchitecture
The web app remains deny-by-default at the browser boundary. Integration logo URLs and the CSP origin share one constant. All sandbox iframes, including noVNC browser takeover, now stay behind the existing
*.trycheatcode.compreview-proxy boundary.Decisions Made
https://logos.composio.devimg-srcoriginremotePatternsunoptimizedreturns the raw source and does not use the optimizer allowlistframe-srcEdge Cases Handled
How to Review
apps/web/next.config.tsandapps/web/src/lib/integration-logo.tsfor the CSP boundary.integration-brand-logo.tsxfor the shared URL builder.project-sandbox-content.tsfor the browser-takeover proxy alignment.Verification
pnpm lintpnpm typecheckpnpm turbo build --forcepnpm turbo skills:buildpnpm deadcodepnpm architecture:checkhttps://logos.composio.dev/api/gmailunder that CSP at 128×128