fix(db): type provisioning format() parameters - #114
Merged
Conversation
format()'s variadic arguments are "any", so Postgres cannot infer bind-parameter types for them; the role-password statement builder failed at first live execution with 'could not determine data type of parameter $1'. Explicit ::text casts fix inference; the vault calls already infer from typed function signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the fresh-project e2e at first live execution of provisioning:
format()'s variadic args are"any", so bind-parameter types cannot be inferred →could not determine data type of parameter $1. Explicit::textcasts on the two parameters. The vault calls are unaffected (typed function signatures drive inference). Repo-wide sweep shows this was the onlyformat()bind site.Verification notes
pnpm lint/pnpm typecheck(single-line SQL string change in an operational script; no build-surface impact — full chain ran green on the identical tree two merges ago)