Handle receiver join failures gracefully in ping expectations #13
+45
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receivers fail to join the group chat (timeout/exception), the script incorrectly expected all original receivers to receive ping messages, causing inflated loss percentages and incorrect exit codes.
Changes
wait_for_receivers_to_join(): Returns(joined_indices, join_errors)tuple instead of just countperform_ping(): Filters receiver list to only successfully joined receivers--- join errors ---section at end of outputmain(): Exit code now based onlen(pinger.receivers)(joined) instead ofargs.numrecipients(requested)Example output when 1 of 3 receivers fails to join
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.