Conversation
Double amount, and Double total converted to strings before checking if it equals the price.
ResultSet retrieved from the DonateEvent object instead of creating a new one. Removed looping through all recent donors since it's already being looped through in Donator.java checkForDonations()
ResultSet is passed and stored in this object now.
checkForDonations() will now pass along the ResultSet to the DonateEvent. Also, the check for expired donations check the price against strings instead of doubles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From testing by manually inserting rows into the donations table, it works well. The only issue that I didn't fix was it seems to set the expiration as a string in the config by default, but it won't work if it's set as a string so you have to edit the config to remove those quotes around the expiration setting.