Repository navigation
workflows: Pre-install just and gh-aw for drafter and fix - #2
Closed
cgwalters-bot wants to merge 3 commits into
Closed
cgwalters-bot wants to merge 3 commits into
cgwalters-bot wants to merge 3 commits into
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cgwalters-bot
force-pushed
the
bot/aw-preinstall-tools
branch
from
September 30, 2026 21:18
876763b to
0369550
Compare
cgwalters
approved these changes
Sep 30, 2026
cgwalters-bot
force-pushed
the
bot/aw-preinstall-tools
branch
from
September 30, 2026 21:44
0369550 to
b6e9744
Compare
`gh extension list` fails when gh isn't logged in, as in the agent sandbox. setup then fell through to `gh extension install`, which needs the network and fails outright when gh-aw was installed without an extension manifest (setup-cli's fallback path). Asking `gh aw version` works in both cases. Prep for pre-installing gh-aw for the drafter and fix agents. Generated-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
The drafter and fix agents are told to recompile lock files after editing a workflow, but they can't install the tools to do it (bootc-dev#109): gh isn't logged in inside the sandbox, api.github.com isn't on the allowlist, and building just from crates.io isn't worth the agent's time even where it's allowed. gh-aw's custom steps and runtimes are set up on the runner before the agent starts, outside the firewall, and AWF exposes the host's binaries and $HOME (where gh keeps extensions) inside the sandbox, so a shared import is enough; no custom runner or container image. The gh-aw runtime installs the CLI at the compiler's own version, which ci.yml already holds to .github/aw/gh-aw-version, so there's no second pin to keep in sync. As a side effect the compiler adds github.github.com (gh-aw's docs) to the agent's allowlist and GitHub's download hosts to the detection job's. Fixes: bootc-dev#109 Generated-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
Collaborator
Author
|
Signed off 2 commit(s) with |
cgwalters-bot
force-pushed
the
bot/aw-preinstall-tools
branch
from
September 30, 2026 21:44
b6e9744 to
618f0b8
Compare
Collaborator
Author
|
Opened upstream as bootc-dev#117. Closing this review draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drafter and fix agents are told to run
just setup && just compileafter editing a workflow, but can't install either tool from inside the AWF sandbox (bootc-dev#109): gh isn't logged in there and api.github.com isn't on the allowlist.This adds a shared import that sets up both on the runner before the agent starts, which gh-aw supports directly, so no custom runner or container image is needed: custom
steps:andruntimes:run outside the firewall (steps and jobs), and AWF exposes the host's binaries and$HOME(where gh keeps extensions) inside the sandbox (host binaries).justcomes from apt; the compiler'sgh-awruntime installs the CLI throughgithub/gh-aw-actions/setup-cliat the compiler's own version, whichci.ymlalready holds to.github/aw/gh-aw-version. A prep commit makesjust setupdetect the installed CLI withgh aw version, sincegh extension listfails when gh isn't logged in.Side effect of the gh-aw runtime: the compiler adds
github.github.comto the agent's allowlist, and GitHub's download hosts to the threat-detection job's.The
ANTHROPIC_API_KEY401/403 warning on bootc-dev#109 is a false positive, not a secret problem: all 31 model calls through the API proxy returned 200. The two 403s were Squid denying direct connections from the agent container to api.anthropic.com, which the firewall blocks by design (only the API proxy may connect).Tested on a devspace: lock files recompiled with gh-aw v0.88.2, and recompiling again gives no drift. Inside
unshare -rnwith no GitHub token,just setup && just compilesucceeds, both with the CLI installed as a gh extension and with it installed by setup-cli's manual fallback. Theci.ymlnode tests pass. actionlint reports the same 28 findings on the workflows as on main, none new. Not run: a live drafter run, since that needs the repository's secrets and App.Fixes bootc-dev#109
Generated-by: https://github.com/cgwalters/#llms
Review draft in cgwalters-forge, not upstream yet. This section is removed when the PR is opened upstream.
bootc-dev/gh-agentic-workflows, basemainPVTI_lADOE9oHIs4BlJLczg9wwPwTo review:
/promoteon a line of its own, to open it upstream, ready for review. Either covers only the commits pushed so far.Signed-off-by: Colin Walters <walters@verbum.org>to the commits lacking it (the bot's and yours; anyone else's only if you ask), with you as committer./draftline (in the same comment or before) to open it upstream as a draft (/readyundoes that).