Repository navigation
tests: Run install config and printconfig --all in one test - #14
Closed
cgwalters-bot wants to merge 1 commit into
Closed
cgwalters-bot wants to merge 1 commit into
cgwalters-bot wants to merge 1 commit into
Conversation
The container tests run in parallel under libtest-mimic, and the printconfig --all test creates and removes /run/bootc/install/10-test.toml while the plain install config test scans that same directory. If the fragment is deleted between the scan and the read, the plain test fails with "Loading configuration: No such file or directory". This showed up as a flake in CI. There's no way to point bootc at a different config root, so just run the two checks sequentially in a single test. Generated-by: AI
Collaborator
Author
|
Superseded by #24, which fixes the same race in config loading and also serializes the two tests; closing. Generated-by: https://github.com/cgwalters/#llms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container integration tests run in parallel under libtest-mimic.
printconfig --allwrites/run/bootc/install/10-test.tomland removes it when it finishes, whileinstall configrunsbootc install print-configuration, which scans that same directory.load_config()lists the fragments first and reads them afterwards. If the file is removed between those two steps, the read fails withLoading configuration: No such file or directory (os error 2). This hit a fork CI run (job log).The config search path is hardcoded, so the
--alltest can't use a separate root. Instead, the two checks now run one after the other in a singleinstall configtest: first the plain read, then the--allone with the fragment.Testing was on a 16-core RHEL 10 devspace with the default
just buildimage (centos-stream10, ostree). Each test run waspodman run ... bootc-integration-tests container config, which selects just these tests.just test-container-integration: 9/9 passed.cargo fmt --checkand the Makefile's gating clippy config pass fortests-integration.It's rare upstream. I searched the logs of every failed job from the last 100
ci.ymlruns on bootc-dev/bootc (about 8 days; 28 jobs whose container-test step failed) and found no hits for this error.bootc requires DCO: the commits have no
Signed-off-by, so a maintainer must sign off before merging (e.g.git rebase --signoff <base>and force-push).Generated-by: https://github.com/cgwalters/#llms
Review draft in cgwalters-forge, not upstream yet. This section is removed when the PR is opened upstream.
bootc-dev/bootc, basemainPVTI_lAHOAQ_SPs4Bj2Gizg8hb8ETo review:
/draft, then approve, to open it upstream as a draft (/readyundoes that).