quiet client-caused 4xx in log_exception - #460
Merged
Merged
Conversation
stefanv
reviewed
Sep 10, 2026
stefanv
reviewed
Sep 10, 2026
| self.render("loginerror.html", app=cfg["app"], error_message=str(err)) | ||
|
|
||
| def log_exception(self, typ=None, value=None, tb=None): | ||
| # Expected conditions raised as plain exceptions, with no status to test. |
Contributor
There was a problem hiding this comment.
I don't understand this comment.
stefanv
reviewed
Sep 10, 2026
stefanv
left a comment
stefanv
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall; would be great if we can clarify the comments here.
Co-authored-by: Stefan van der Walt <stefan@mentat.za.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some 4xx that made it to Sentry as "errors."