chore!: remove AlarmSeverities (use alarmOverrides instead)

src/api.ts

@@ -42,25 +42,6 @@ export enum AlarmSeverity {
   LOW,
 }
 
-/**
- * Configure severities for various alarms.
- *
- * Alarms not included here are currently not configurable.
- */
-export interface AlarmSeverities {
-
-  /**
-   * @default AlarmSeverity.HIGH
-   */
-  readonly backendOrchestrationFailed?: AlarmSeverity;
-
-  /**
-   * @default AlarmSeverity.LOW
-   */
-  readonly packageCanarySLABreached?: AlarmSeverity;
-
-}
-
 /**
  * An override for a specific alarm.
  */

src/backend/orchestration/index.ts

@@ -32,7 +32,7 @@ import { Construct } from 'constructs';
 import { NeedsCatalogUpdate } from './needs-catalog-update';
 import { RedriveStateMachine } from './redrive-state-machine';
 import { RetryUninstallablePackages } from './retry-uninstallable-packages';
-import { AlarmSeverities, AlarmSeverity } from '../../api';
+import { AlarmSeverity } from '../../api';
 import { Repository } from '../../codeartifact/repository';
 import { sqsQueueUrl, stateMachineUrl } from '../../deep-link';
 import { Monitoring, addAlarm } from '../../monitoring';
@@ -157,11 +157,6 @@ export interface OrchestrationProps {
    * The construct that generates RSS/ATOM feed
    */
   readonly feedBuilder: FeedBuilder;
-
-  /**
-   * Configure alarm severities.
-   */
-  readonly alarmSeverities?: AlarmSeverities;
 }
 
 /**
@@ -503,7 +498,7 @@ export class Orchestration extends Construct {
           evaluationPeriods: 1,
           threshold: 1,
         }),
-      props.alarmSeverities?.backendOrchestrationFailed ?? AlarmSeverity.HIGH,
+      AlarmSeverity.HIGH,
       props.monitoring
     );
 

src/construct-hub.ts

@@ -12,7 +12,7 @@ import * as sqs from 'aws-cdk-lib/aws-sqs';
 import { IStateMachine } from 'aws-cdk-lib/aws-stepfunctions';
 import { Construct } from 'constructs';
 import { createRestrictedSecurityGroups } from './_limited-internet-access';
-import { AlarmActions, AlarmOverride, AlarmSeverities, Domain } from './api';
+import { AlarmActions, AlarmOverride, Domain } from './api';
 import { DenyList, Ingestion } from './backend';
 import { DenyListRule } from './backend/deny-list/api';
 import { FeedBuilder } from './backend/feed-builder';
@@ -77,11 +77,6 @@ export interface ConstructHubProps {
    */
   readonly alarmActions?: AlarmActions;
 
-  /**
-   * Configure the severities of various alarms.
-   */
-  readonly alarmSeverities?: AlarmSeverities;
-
   /**
    * Per-alarm overrides keyed by the alarm's CloudWatch display name relative
    * to the `ConstructHub` construct — i.e. the same string a customer sees in
@@ -434,7 +429,6 @@ export class ConstructHub extends Construct implements iam.IGrantable {
       vpcSubnets,
       vpcSecurityGroups,
       feedBuilder,
-      alarmSeverities: props.alarmSeverities,
     });
     this.regenerateAllDocumentationPerPackage =
       orchestration.regenerateAllDocumentationPerPackage;
@@ -508,9 +502,7 @@ export class ConstructHub extends Construct implements iam.IGrantable {
 
     const sources = new Construct(this, 'Sources');
     const packageSources = (
-      props.packageSources ?? [
-        new NpmJs({ alarmSeverities: props.alarmSeverities }),
-      ]
+      props.packageSources ?? [new NpmJs()]
     ).map((source) =>
       source.bind(sources, {
         baseUrl: webApp.baseUrl,

src/package-sources/npmjs.ts

@@ -19,7 +19,7 @@ import { SqsEventSource } from 'aws-cdk-lib/aws-lambda-event-sources';
 import { BlockPublicAccess, IBucket } from 'aws-cdk-lib/aws-s3';
 import { Queue, QueueEncryption } from 'aws-cdk-lib/aws-sqs';
 import { Construct } from 'constructs';
-import { AlarmSeverities, AlarmSeverity } from '../api';
+import { AlarmSeverity } from '../api';
 import { lambdaFunctionUrl, s3ObjectUrl, sqsQueueUrl } from '../deep-link';
 import { fillMetric } from '../metric-utils';
 import { addAlarm } from '../monitoring';
@@ -106,11 +106,6 @@ export interface NpmJsProps {
    * @default Duration.days(1)
    */
   readonly canaryMaxStale?: Duration;
-
-  /**
-   * Configure alarm severities.
-   */
-  readonly alarmSeverities?: AlarmSeverities;
 }
 
 /**
@@ -647,7 +642,7 @@ export class NpmJs implements IPackageSource {
     addAlarm(
       'New version visibility SLA breached',
       alarm,
-      this.props.alarmSeverities?.packageCanarySLABreached ?? AlarmSeverity.LOW,
+      AlarmSeverity.LOW,
       monitoring
     );