Sourcery Starbot ⭐ refactored ccombe/practical-python by SourceryAI · Pull Request #1 · ccombe/practical-python

SourceryAI · 2020-10-11T10:28:34Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/practical-python master
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI · 2020-10-11T10:28:36Z

Solutions/1_10/mortgage.py

-    month = month + 1
+    month += 1
    principal = principal * (1+rate/12) - payment
-    total_paid = total_paid + payment
+    total_paid += payment

    if month >= extra_payment_start_month and month <= extra_payment_end_month:
-        principal = principal - extra_payment
-        total_paid = total_paid + extra_payment
+        principal -= extra_payment
+        total_paid += extra_payment

    print(month, round(total_paid,2), round(principal, 2))
-    
+


Lines 14-23 refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

SourceryAI · 2020-10-11T10:28:36Z

Solutions/1_33/pcost.py

-else:
-    filename = input('Enter a filename:')
-
+filename = sys.argv[1] if len(sys.argv) == 2 else input('Enter a filename:')


Lines 25-29 refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2020-10-11T10:28:36Z

Solutions/1_5/bounce.py

-bounce = 1
-while bounce <= 10:
-    height = height * (3/5)
+for bounce in range(1, 11):
+    height *= 3/5
    print(bounce, round(height, 4))
-    bounce += 1


Lines 4-8 refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

Replace while with for (while-to-for)

SourceryAI · 2020-10-11T10:28:37Z

Solutions/2_16/pcost.py

-else:
-    filename = input('Enter a filename:')
-
+filename = sys.argv[1] if len(sys.argv) == 2 else input('Enter a filename:')


Lines 26-30 refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2020-10-11T10:28:37Z

Solutions/3_10/fileparse.py

-                record = dict(zip(headers, row))
-            else:
-                record = tuple(row)
+            record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2020-10-11T10:28:40Z

Solutions/4_10/report.py


-    portfolio = [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]
-    return portfolio
+    return [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]


Function read_portfolio refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2020-10-11T10:28:41Z

Solutions/4_4/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2020-10-11T10:28:41Z

Solutions/4_4/pcost.py

    '''
    portfolio = report.read_portfolio(filename)
-    return sum([s.cost() for s in portfolio])
+    return sum(s.cost() for s in portfolio)


Function portfolio_cost refactored with the following changes:

Replace unneeded comprehension with generator (comprehension-to-generator)

SourceryAI · 2020-10-11T10:28:42Z

Solutions/4_4/report.py


-    portfolio = [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]
-    return portfolio
+    return [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]


Function read_portfolio refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2020-10-11T10:28:42Z

Solutions/5_8/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2020-10-11T10:28:45Z

Solutions/5_8/pcost.py

    '''
    portfolio = report.read_portfolio(filename)
-    return sum([s.cost() for s in portfolio])
+    return sum(s.cost() for s in portfolio)


Function portfolio_cost refactored with the following changes:

Replace unneeded comprehension with generator (comprehension-to-generator)

SourceryAI · 2020-10-11T10:28:45Z

Solutions/5_8/report.py


-    portfolio = [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]
-    return portfolio
+    return [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]


Function read_portfolio refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2020-10-11T10:28:45Z

Solutions/6_12/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2020-10-11T10:28:46Z

Solutions/6_12/portfolio.py


    def __contains__(self, name):
-        return any([s.name == name for s in self._holdings])
+        return any(s.name == name for s in self._holdings)


Function Portfolio.__contains__ refactored with the following changes:

Replace unneeded comprehension with generator (comprehension-to-generator)

SourceryAI · 2020-10-11T10:28:46Z

Solutions/6_12/portfolio.py

    @property
    def total_cost(self):
-        return sum([s.shares * s.price for s in self._holdings])
+        return sum(s.shares * s.price for s in self._holdings)


Function Portfolio.total_cost refactored with the following changes:

Replace unneeded comprehension with generator (comprehension-to-generator)

SourceryAI · 2020-10-11T10:28:49Z

Solutions/8_1/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2020-10-11T10:28:50Z

Solutions/8_2/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2020-10-11T10:28:50Z

Solutions/9_3/porty-app/porty/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2020-10-11T10:28:50Z

Solutions/9_5/porty-app/porty/fileparse.py

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2020-10-11T10:28:51Z

Work/Data/stocksim.py

 def csv_record(fields):
-    s = '"%s",%0.2f,"%s","%s",%0.2f,%0.2f,%0.2f,%0.2f,%d' % tuple(fields)
-    return s
+    return '"%s",%0.2f,"%s","%s",%0.2f,%0.2f,%0.2f,%0.2f,%d' % tuple(fields)


Function csv_record refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

'Refactored by Sourcery'

4d09d6d

SourceryAI commented Oct 11, 2020

View reviewed changes

Conversation

SourceryAI commented Oct 11, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant