fix(l1): bump EIP-1559 fees on same-nonce poster retries - #34
Open
stephenctw wants to merge 5 commits into
Open
Conversation
Collaborator
Author
|
@jplgarcia FYI |
Track in-flight fees and floor re-estimates to the shared ≥10% replacement rule so flat markets cannot underprice replacements.
Add mixed-component fees_for_nonce coverage, seeded replacement floor, Latest prune, and failed-send non-record assertions.
stephenctw
force-pushed
the
fix/poster-replacement-fee-bump
branch
from
August 18, 2026 11:55
9e084bc to
77a4a61
Compare
A 200ms sleep raced the first spawn_blocking SQLite write on loaded CI, so the assertion still saw the default log_gas_price of 0.
Grow max_fee and priority by the same ×1.1+1 factor and clamp tip ≤ cap so poster retries cannot wedge on ErrTipAboveFeeCap. Only the blocking (Latest) nonce is re-escalated; suffix txs keep their original hash.
When a same-nonce send is rejected as replacement-underpriced, immediately raise the stored head-nonce floor from the attempted fees so the next tick self-corrects instead of repeating the same underpriced pair.
Collaborator
Author
|
Fixes the permanent poster wedge from asymmetric replacement bumps; limits re-escalation to the head nonce; adds geth underpriced fast-path floor raise. |
stephenctw
force-pushed
the
fix/poster-replacement-fee-bump
branch
from
August 20, 2026 13:08
812e198 to
b09dbc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes same-nonce batch-poster retries that could rebroadcast underpriced EIP-1559 replacements when the fee market was flat. The poster now tracks in-flight fees per wallet nonce and floors each re-estimate against a shared ≥10% replacement bump (max fee ×1.1 +1; priority ×2), matching the mempool flusher’s rule.
bumped_replacement_feesintol1::eip1559and addfees_for_nonceso poster + flusher share one replacement policy.Test plan
cargo test -p sequencer --lib eip1559cargo test -p sequencer --lib submitter::posterbumped_replacement_fees(cargo test -p sequencer --lib recovery::flusher)submit_batches_replacement_clears_ten_percent_bump)