Expand CI coverage across platforms#298
Merged
mattalvarado merged 37 commits intoJun 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mattalvarado
approved these changes
Jun 3, 2026
Collaborator
mattalvarado
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Contributor
Author
Happy to! FYI won't let me merge since the old CI status checks never ran (since they don't exist anymore). Might need to disable those specific status checks in the repo settings. Or maybe just need somebody with maintainer rights to make the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make some improvements to CI:
BUILD_OPENCVflag (which breaks some things).2026.04.27release.Implementation Details
All Workflows
The OS-specific build is broken out to a distinct workflow with parameters dictating the build configuration. See the
.github/workflows/build-*.ymlfiles.Windows Workflows
The dependencies for these are built with vcpkg, and that build can take a long time. There is an additional
build-windows-vcpkg-dependencies.ymlwhich performs a single, common build of the dependencies then caches them. These cached dependencies are then downloaded to each Windows runner. The cached dependencies are only rebuilt when either of thevcpkg.jsonor thevcpkg-configuration.jsonfiles are modified.As a result, the first-time the CI runs there will be an hour-long run to build these dependencies, but all subsequent builds should be much faster.
Comprehensive List of Checks
Build/Install/Consume
These check whether the software builds on this OS/compiler/build configuration, runs the unit test suite, and then attempts to build a toy project that depends on the
Miscellaneous
These are additional checks that perform a specific task.
Notes
MULTISENSE_APIusage of_MSC_VERwhere_WIN32would be more apt #300.Future TODOs
release.ymlworkflow to instead use the parameterized build workflows.