feat: snapcast control UI setVolume - #55
Merged
Merged
Conversation
gsalinaslopez
force-pushed
the
feat/snapcast-control-ui-setvolume
branch
from
November 20, 2025 02:58
238423a to
0dbdd19
Compare
guerman5
approved these changes
Nov 20, 2025
guerman5
left a comment
guerman5
left a comment
Contributor
There was a problem hiding this comment.
Nice addition — per-client Snapcast volume control clearly improves usability by letting users fine-tune multi-device playback without leaving the app. The UI should feel immediate and trustworthy: show a numeric readout, provide mute and +/- step buttons, and visually indicate when a change is syncing or failed.
Must-fix items: debounce slider updates (150–300ms) and send a final value on release to avoid flooding the server; use optimistic UI with a subtle “syncing” indicator and rollback on error with a retry snackbar; and ensure accessibility (TalkBack labels/contentDescription, >=48dp touch targets, dynamic type).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes