feat: sl4j android logger implementation - #52
Merged
Conversation
…a: com.gitlab.mvysny.slf4j:slf4j-handroid)
guerman5
approved these changes
Oct 29, 2025
guerman5
left a comment
guerman5
left a comment
Contributor
There was a problem hiding this comment.
Excellent, this is a must tool for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
librespot has a sl4j logger dependency that the project is not providing an implementation for:
Causing potential log messages from librespot to be skipped during development.
In this PR we introduce the sl4j android logger implementation via: com.gitlab.mvysny.slf4j:slf4j-handroid
Example
logging:
which comes from the upstream librespot project: https://github.com/librespot-org/librespot-java/blob/90978c1ce60b40344e3a6f70dae560b9c9a8a818/player/src/main/java/xyz/gianlu/librespot/player/playback/PlayerQueueEntry.java#L125