Webapp-overlay gate, timeout ceilings, dependabot coverage for the html5 module - #27
Merged
Merged
Conversation
…from The published app ships the same 61 webapp files twice - the vendored core's app/z2ui5/webapp and the overlay assemble-cap.js copies to app/z2ui5/webapp so cds watch, the approuter and ui5 build find a real CAP app folder. The copy is deliberate (a symlink survives neither a Windows checkout nor an mbt archive); what was missing is the gate that keeps 'twice' from becoming 'two versions' - an overlay edited in place, or left stale by a partial run, drifts silently between what the browser gets and what the framework serves. src/test/webapp-overlay.test.js proves the two trees byte-identical. It ships with the app, so it runs in the assemble's publish gate AND in the published repository's own CI; in this builder checkout, where no overlay exists yet, the byte half skips and only the source side is asserted. Green: 10 suites, 53 tests over the assembled app. mirror-core.js additionally names its twin: the honor-the-pin-only- when-newer arbitration exists a second time in builder-cap2UI5-web's mirror.mjs, and each header now points at the other. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
Same test as in builder-abap2UI5-js, reading only this repository's own AGENTS.md and README.md: the linked repo sets of the two ecosystem tables must agree, the wording stays free. The self row is a wording convention (README links it, AGENTS bolds it) and is dropped. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
CONVENTIONS §6 asks every repository carrying ABAP or generated trees for a .gitattributes; this one commits the mirrored core package and had none, so a CRLF checkout re-committing the mirror would have turned every line into a diff. The src/ copy ships into the published cap2UI5 app, whose content outside .github/ can only come from here - verified: assemble carries it into the output and all 10 suites stay green. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
…ml5 module abap2UI5 sets timeout-minutes on all of its jobs and most repositories follow; here neither job had a ceiling, and update_cap pushes to the app repo - a hung run held that pipeline for GitHub's six-hour default. dependabot also never saw src/app/z2ui5/package.json (@ui5/cli ^4.0.0) - directory is not recursive, and this is the same nobody-covered-this -manifest story the config's own root-manifest comment records. The html5 module's manifest is covered now; as with every app dependency, here is the only place a bump survives the nightly publish. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four commits from the 2026-08-30 ecosystem review:
src/test/webapp-overlay.test.js: the published app ships the same 61 webapp files twice — the vendored core's tree and the overlay assemble-cap.js copies forcds watch/approuter/ui5 build. The copy is deliberate (a symlink survives neither a Windows checkout nor an mbt archive); what was missing is the gate that keeps "twice" from becoming "two versions". The test proves the trees byte-identical, ships with the app (runs in the publish gate AND the published repo's CI), and in this builder checkout asserts the source side only. Green: 10 suites / 53 tests over the assembled app.mirror-core.jsnames its twin: the honor-the-pin-only-when-newer arbitration exists a second time in builder-cap2UI5-web'smirror.mjs; each header now points at the other.src/app/z2ui5/package.json(@ui5/cli— the same nobody-covered-this-manifest story the config's own comment records for the root),src/.gitattributesfor the mirrored generated tree, and the ecosystem-table consistency test shared with builder-abap2UI5-js.🤖 Generated with Claude Code
https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
Generated by Claude Code