Add mainnet history dump user GCP SA#5737
Conversation
|
|
||
| export const ghaConfig = fullConfig.gha; | ||
|
|
||
| export const isSpliceCluster = |
There was a problem hiding this comment.
No need to guard for splice
| .default([]), | ||
| mainnetHistoryDumpsUser: z | ||
| .object({ | ||
| bucket: z.string().min(1), |
There was a problem hiding this comment.
What's the min(1)? I don't recall seeing us doing that elsewhere. It's preventing an empty string basically?
There was a problem hiding this comment.
Yes, making sure empty strings are not passed to GCP APIs.
| // GitHub repos (full "org/name") allowed to impersonate the SA via WIF. | ||
| githubRepositories: z.array(z.string().min(1)).min(1), | ||
| }) | ||
| .optional(), |
There was a problem hiding this comment.
Consider not even making this optional. We deploy gha only in one place, and we want to use it there.
There was a problem hiding this comment.
Done. Until the conifg.yml is merged from network-internals, this will end up in an error if another 'pulumi up' executed.
There was a problem hiding this comment.
Yeah, I thought of that too. Initially I thought it's fine, and you just merge your other PR quickly. But given that that might be a bit tricky to get fully working, with permissions etc., maybe it's better for now to keep it optional so that we can always easy not apply it yet? And then at a later stage once everything is applied, drop the optional.
| mainnetHistoryDumpsUser: z | ||
| .object({ | ||
| bucket: z.string().min(1), | ||
| wifProjectNumber: z.string().min(1), |
There was a problem hiding this comment.
Can/should this be an int instead of string?
There was a problem hiding this comment.
project number is eventually used in a string for IAM role config; string is the way to go.
[static] Signed-off-by: Jagath Weerasinghe <jagath.weerasinghe@digitalasset.com>
[static] Signed-off-by: Jagath Weerasinghe <jagath.weerasinghe@digitalasset.com>
[static] Signed-off-by: Jagath Weerasinghe <jagath.weerasinghe@digitalasset.com>
jagathweerasinghe-da
force-pushed
the
wee/add_gcp_sa_for_gcs_dump_data_mgmt
branch
from
ffd1d3e to
40d1a04
Compare
[static] Signed-off-by: Jagath Weerasinghe <jagath.weerasinghe@digitalasset.com>
[static] Signed-off-by: Jagath Weerasinghe <jagath.weerasinghe@digitalasset.com>
2 participants
[static]
Configured by: https://github.com/DACH-NY/canton-network-internal/pull/5116