Make sure that we can run locking on GitHub Actions#5675
Merged
Conversation
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
50da662 to
1d28435
Compare
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Contributor
Author
|
/cluster_test |
|
Deploy cluster test triggered for Commit f70c859cbbc87ff505b13cfa71ce01974573ae34 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/67311 |
martinflorian-da
approved these changes
May 28, 2026
Contributor
martinflorian-da
left a comment
There was a problem hiding this comment.
Looks reasonable, thank you!
| # Check lock for CI... | ||
| if ! approver=$( "$SPLICE_ROOT/build-tools/approved-by.sh" ); then | ||
| _error "Could not determine approver for CI workflow" | ||
| approver="" |
Contributor
There was a problem hiding this comment.
nit: consider making this local
Co-authored-by: Martin Florian <martin.florian@digitalasset.com> Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that we can verify the locker of scratchnets on GHA.
For context:
$SPLICE_ROOT/build-tools/approved-by.shcould not execute as the job did not have CCI token (and it does not make sense under GHA anyway)Solution:
GITHUB_ACTOR(orGITHUB_TRIGGERING_ACTOR)Refs: