Skip to content

fix(api): preserve existing database secrets - #43

Merged
calltelemetry-jason merged 1 commit into
mainfrom
fix/REL-255-existing-api-secret
Aug 9, 2026
Merged

fix(api): preserve existing database secrets#43
calltelemetry-jason merged 1 commit into
mainfrom
fix/REL-255-existing-api-secret

Conversation

@calltelemetry-jason

@calltelemetry-jason calltelemetry-jason commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • stop rendering a generated api-db-secret when db.useExistingSecret=true
  • keep workload secret references pointed at the operator-provided Kubernetes Secret
  • add a Helm unit test proving no generated Secret is emitted and references remain present

Verification

  • tests/unit/test-api-existing-secret.sh (passed: 10 references, no generated Secret)
  • helm lint helm/charts/api --set db.useExistingSecret=true --set db.existingSecretName=api-db-secret (passed)

Context

This unblocks the reproducible backend DevSpace lane needed for REL-255 without placing database credentials in source. It does not close tenant/appliance acceptance by itself.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 40222630-7932-4e67-9cd1-ba7b2ad5d398

📥 Commits

Reviewing files that changed from the base of the PR and between ce57a3c and 37746a6.

📒 Files selected for processing (2)
  • helm/charts/api/templates/db_secret.yaml
  • tests/unit/test-api-existing-secret.sh

Comment @coderabbitai help to get the list of available commands.

@calltelemetry-jason
calltelemetry-jason merged commit 2684880 into main Aug 9, 2026
7 checks passed
@calltelemetry-jason
calltelemetry-jason deleted the fix/REL-255-existing-api-secret branch August 9, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant