feat: add shared test targets to impact selection#18
Closed
V3RON wants to merge 1 commit into
Closed
Conversation
Append sharedTargets to every test entry before impact matching and validate config input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This PR adds
tests.sharedTargets, a config field for source targets that should apply to every test map entry. It covers shared setup modules that reach into the rest of the app so Sniffler can still consider every affected test when those modules change.How does it work?
Sniffler now validates
tests.sharedTargetsas a string array and defaults it to[]for backward compatibility. During impact selection, it loads the test map as before, then appends the shared targets to each test entry before matching against the dependency graph. Matching still uses the graph and existing exact/glob semantics, so a change insrc/some-other.tscan select tests through the pathsrc/some-other.ts -> src/global.tswithout bypassing traversal.Why is this useful?
This keeps global setup files in the normal impact-analysis flow instead of special-casing them.
shared-root [1441 files]: 41.5543 hz,deep-branch [1441 files]: 84.3298 hz), which suggests the shared-target expansion does not add a new hot path.