switch to client_ip instead of remote_ip#46
Open
fliespl wants to merge 2 commits intocaddyserver:masterfrom
Open
switch to client_ip instead of remote_ip#46fliespl wants to merge 2 commits intocaddyserver:masterfrom
fliespl wants to merge 2 commits intocaddyserver:masterfrom
Conversation
Handles cases with load balancers when caddy already verified source (i.e. cloudflare)
Member
|
I think if we make that change, it should mention that |
|
On Caddy server 2.10.0, both client_ip and real_ip are same if In this way, if client_ip is not present, real_ip is used. Yet, when |
Member
The format of assuming a default value isn't supported by the transform-encoder module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles cases with load balancers when caddy already verified source (i.e. cloudflare)
Resolves: #45