fix(gcp-bigquery): add CloudError handling and injectable auth#163
Open
atharva-nagane wants to merge 1 commit into
Open
fix(gcp-bigquery): add CloudError handling and injectable auth#163atharva-nagane wants to merge 1 commit into
atharva-nagane wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162
Migrates
BigQueryto returnCloudErrorinstead ofBox<dyn std::error::Error>, checking the HTTP status on every response and mapping 4xx/5xx to the right variant via a newmap_bigquery_http_errorhelper.Adds
Arc<dyn TokenProvider>injection and awith_http_clientconstructor, mirroring the pattern already used byVertexAiProvider, so the client can be exercised in tests without a service account file.Moves the existing live tests behind
#[ignore]and adds unit tests for URL building, error mapping, and token refresh.