fix OutOfMemory bug

[hnvn]

I've removed FfmpegFrameFilter out of my project order to tackle OutOfMemory problem

[saudet]

Sounds good, but please resolve the conflicts! Thanks

[saudet]

Could you somehow make the changes optional, by leaving it up to the user to use either FFmpeg or OpenCV via a static boolean flag, for example? It would be nice to keep both code examples.

[hnvn]

My OutOfMemory problem comes from FFmpegFrameFilter, I don't know how to fix this bug if still using FFmpeg.

[saudet]

That's fine, it might be a bug in JavaCV :)

[hnvn]

Another reason, I implement CvCameraPreview tend to use with OpenCV, so it should only depend on OpenCV library. FFmpeg is a quite big library. Keep my class independents on FFmpeg help me reduce my application size.

[saudet]

That's fine, I would just like to keep the example code somewhere for others to reference, that's all! Maybe as a separate class or something. What do you think?

[hnvn]

I don't think my old code with FFmpeg is a good practice.

[saudet]

Why not? Some people may simply want to record all the frames into a video file, in which case we would not need OpenCV, so it makes sense to do it with FFmpeg in that case.

[hnvn]

No, I mean my code with FFmpeg is not good enough to be an example because it still contains bugs. I don't want to expose the code contain bugs for everyone.

[saudet]

Ah, I see what is wrong. We should move the call to filter.start() right after filter.setPixelFormat(AV_PIX_FMT_NV21), and the one to filter.stop() right before filter.release(). That should fix the memory issue.

[hnvn]

Ok, I will try, test and get back to you soon.

[saudet]

Any updates? Have you had some time to check it out?