Skip to content

Add a enabled: bool parameter to MemFlags modifiers - #14907

Merged
cfallin merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:allow-setting-falase
Oct 24, 2026
Merged

cfallin merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:allow-setting-falase

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

This is an API change for MemFlags to allow disabling flags in addition to disabling them. This came up during #14683 as a possibly useful primitive to have, and subjectively I've found this sort of builder/setting configuration pretty flexible to use historically too.

This is an API change for `MemFlags` to allow disabling flags in
addition to disabling them. This came up during bytecodealliance#14683 as a possibly
useful primitive to have, and subjectively I've found this sort of
builder/setting configuration pretty flexible to use historically too.
@alexcrichton
alexcrichton requested a review from a team as a code owner October 21, 2026 16:09
@alexcrichton
alexcrichton requested review from cfallin and removed request for a team October 21, 2026 16:09
@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. labels Oct 21, 2026
@cfallin
cfallin added this pull request to the merge queue Oct 23, 2026
Merged via the queue into bytecodealliance:main with commit 25fbc44 Oct 24, 2026
53 checks passed
@alexcrichton
alexcrichton deleted the allow-setting-falase branch October 24, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants