Repository navigation
deps(rumqttc): bump rustls-webpki to 0.103 - #1072
Closed
jedwards1230 wants to merge 1 commit into
Closed
jedwards1230 wants to merge 1 commit into
jedwards1230 wants to merge 1 commit into
Conversation
rustls-webpki 0.102.8 has four open advisories: - GHSA-82j2-j2ch-gfr8 (high) DoS via panic on a malformed CRL BIT STRING - GHSA-pwjx-qhcg-rvj4 (medium) CRLs not considered authoritative by distribution point - GHSA-xgp8-3hg3-c2mh (low) name constraints accepted for a wildcard-name certificate - GHSA-965h-392x-2mh5 (low) name constraints for URI names incorrectly accepted All four are fixed in 0.103.13. rumqttc uses exactly one item from this crate — `webpki::Error`, in the `Error::WebPki` variant of src/tls.rs — and that type is unchanged between 0.102 and 0.103, so the bump needs no source changes. Verified with: cargo build --no-default-features --features use-rustls-no-provider cargo build --no-default-features --features use-rustls Downstream crates currently inherit the vulnerable copy transitively with no way to override it: ^0.102.8 cannot resolve to 0.103.x, so a [patch.crates-io] entry cannot bridge the gap and the pin has to move here.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
rumqttc'srustls-webpkipin from0.102.8to0.103.13.rustls-webpki0.102.8 has four open advisories, all fixed in 0.103.13:Why this has to change here
Downstream crates cannot work around it from their own manifests.
^0.102.8does not admit
0.103.x, so a[patch.crates-io]entry forrustls-webpkiisapplied to whatever other 0.103 edge exists in the graph (the one
rustls0.23 already pulls) and leaves
rumqttc's untouched — the lockfile just grows athird copy. The pin has to move in this crate.
That is currently the situation for anyone using
rumqttcwith a rustlsfeature:
rustls0.23 resolvesrustls-webpki0.103.x correctly, andrumqttcpulls 0.102.8 in beside it.Why it is a one-line change
rumqttcuses exactly one item from the crate —webpki::Error, in theError::WebPkivariant ofsrc/tls.rs. Everything else in that module comesfrom
rustlsviatokio_rustls::rustls::{...}, and the root store is builtwith
rustls::RootCertStore::add_parsable_certificates.webpki::Errorisunchanged between 0.102 and 0.103, so no source changes are needed.
Verification
Both rustls feature legs build clean against 0.103 with no source edits:
Happy to adjust the version requirement (e.g.
"0.103"rather than the exact"0.103.13") or to split it differently if you'd prefer.