Use better names in CI and put checkgenerate into separate step#479
Open
Use better names in CI and put checkgenerate into separate step#479
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
stefanvanburen
approved these changes
Mar 11, 2026
| make checkgenerate | ||
| - run: make test-go | ||
| - run: make lint-go | ||
| - run: mkdir -p .tmp/bin && cp $(which buf) .tmp/bin/buf |
Member
There was a problem hiding this comment.
I realize that this is the existing behavior, but it feels somewhat weird to get the latest buf binary from (presumably?) buf-action with setup_only and sidestep the pinned buf in the Makefile, but probably fine in the sense that it shouldn't change generation/formatting anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames workflows and jobs for better readability:
Other changes:
fetch-depth: 2, so this drops the setting to rely on the default.Looks like branch protection rules need an update - I'll sort this out after review.