Make the plugin gate run somewhere other than this laptop - #26
Merged
Merged
Conversation
The gate list I have been following includes `omarchy plugin validate .`, and CI has never run it, because it only exists on an Omarchy machine. So the desktop side of this repo has had a check that runs when someone remembers to type it, which is the same as no check. bin/check-plugin.mjs is the portable part of it, now in CI: no tracked symlinks (the loader refuses them, and that is the failure that stops an install), a manifest whose entry points exist on disk, and the version numbers this repo has drifted apart before (manifest.json, website/package.json, and the newest tag when the checkout has tags). qmllint runs when the machine has it and is skipped with a note when it does not, so the same script is useful locally and harmless on a runner. Found while checking this: `omarchy plugin validate` also fails in the dev clone once `website/node_modules` exists, because it walks the folder and 44 of npm's .bin entries are symlinks. It passes with node_modules aside. Nothing to fix in the repo, but worth knowing before someone chases a red gate that is not real.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
typearchy | abfc804 | Commit Preview URL Branch Preview URL |
Sep 20 2026, 09:28 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gate list I have been following includes
omarchy plugin validate .. CI has never run it, because the command only exists on an Omarchy machine. That means the desktop side of this repo has had a check that runs when someone remembers to type it, which is the same as no check, and it is exactly the failure mode Phase 3 has been hunting: a green light that proves nothing.bin/check-plugin.mjsis the portable part, now in CI:manifest.json,website/package.json, and the newest tag when the checkout has tags (a shallow CI checkout has none, so that comparison skips rather than failing falsely)qmllint, skipped with a note when it does notIt passes on main: no tracked symlinks, 2 entry points resolve, version 1.5.0 matches the website package and the newest tag.
One thing found on the way, recorded rather than fixed:
omarchy plugin validatealso fails in the dev clone oncewebsite/node_modulesexists, because it walks the folder and 44 of npm's.binentries are symlinks. It passes withnode_modulesmoved aside. Nothing is wrong with the repo, but the local gate goes red for a reason that has nothing to do with the plugin.No product code changes.