chore: remove tools/* packages, consume @btravstack config directly - #591
Merged
Conversation
Follow-up to the shared-config adoption: delete the local tools/tsconfig and
tools/typedoc packages entirely and point every consumer directly at the
published @btravstack/tsconfig / @btravstack/typedoc via the catalog.
- delete tools/tsconfig, tools/typedoc; drop tools/* from the workspace globs
- consumers (packages, examples, tests): extends @btravstack/{tsconfig,typedoc}/base.json;
devDeps workspace:* -> catalog: (tests/tsconfig.json used a relative ../tools path)
- drop the now-unused @btravstack/tsconfig from docs (no docs tsconfig)
- ignore the private examples/docs/tests packages in changesets; patch the published fixed group
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the repository-local tools/tsconfig and tools/typedoc workspace packages and updates all consumers to extend the published @btravstack/tsconfig and @btravstack/typedoc configurations directly via the pnpm catalog, aligning the monorepo with the shared-config adoption work.
Changes:
- Deleted
tools/tsconfigandtools/typedocand removedtools/*from workspace package globs. - Updated all package/example/test TypeScript + TypeDoc configs to extend
@btravstack/*directly and adjusted devDependencies accordingly. - Updated Changesets config to ignore private workspaces (examples/docs/tests) and added a patch changeset for the fixed published group; adjusted Knip ignores to match the new dependency surface.
Reviewed changes
Copilot reviewed 37 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/typedoc/package.json | Removed local typedoc config package. |
| tools/typedoc/CHANGELOG.md | Removed changelog for deleted typedoc config package. |
| tools/typedoc/base.json | Removed local typedoc base config shim. |
| tools/tsconfig/package.json | Removed local tsconfig package. |
| tools/tsconfig/CHANGELOG.md | Removed changelog for deleted tsconfig package. |
| tools/tsconfig/base.json | Removed local tsconfig base config shim. |
| tests/tsconfig.json | Switched tests TS config to extend @btravstack/tsconfig. |
| tests/package.json | Added @btravstack/tsconfig devDependency for TS config resolution. |
| pnpm-workspace.yaml | Dropped tools/* from workspace packages list. |
| pnpm-lock.yaml | Updated lockfile to remove tools/* importers and switch consumers to @btravstack/*. |
| packages/worker/typedoc.json | Switched TypeDoc config to extend @btravstack/typedoc. |
| packages/worker/tsconfig.json | Switched TS config to extend @btravstack/tsconfig. |
| packages/worker/package.json | Replaced local config devDeps with @btravstack/{tsconfig,typedoc}. |
| packages/testing/typedoc.json | Switched TypeDoc config to extend @btravstack/typedoc. |
| packages/testing/tsconfig.json | Switched TS config to extend @btravstack/tsconfig. |
| packages/testing/package.json | Replaced local config devDeps with @btravstack/{tsconfig,typedoc}. |
| packages/core/typedoc.json | Switched TypeDoc config to extend @btravstack/typedoc. |
| packages/core/tsconfig.json | Switched TS config to extend @btravstack/tsconfig. |
| packages/core/package.json | Replaced local config devDeps with @btravstack/{tsconfig,typedoc}. |
| packages/contract/typedoc.json | Switched TypeDoc config to extend @btravstack/typedoc. |
| packages/contract/tsconfig.json | Switched TS config to extend @btravstack/tsconfig. |
| packages/contract/package.json | Replaced local config devDeps with @btravstack/{tsconfig,typedoc}. |
| packages/client/typedoc.json | Switched TypeDoc config to extend @btravstack/typedoc. |
| packages/client/tsconfig.json | Switched TS config to extend @btravstack/tsconfig. |
| packages/client/package.json | Replaced local config devDeps with @btravstack/{tsconfig,typedoc}. |
| packages/asyncapi/typedoc.json | Switched TypeDoc config to extend @btravstack/typedoc. |
| packages/asyncapi/tsconfig.json | Switched TS config to extend @btravstack/tsconfig. |
| packages/asyncapi/package.json | Replaced local config devDeps with @btravstack/{tsconfig,typedoc}. |
| knip.json | Updated ignored deps to reflect removal of local config packages. |
| examples/basic-order-processing-worker/tsconfig.json | Switched example worker TS config to extend @btravstack/tsconfig. |
| examples/basic-order-processing-worker/package.json | Replaced local tsconfig devDep with @btravstack/tsconfig. |
| examples/basic-order-processing-contract/tsconfig.json | Switched example contract TS config to extend @btravstack/tsconfig. |
| examples/basic-order-processing-contract/package.json | Replaced local tsconfig devDep with @btravstack/tsconfig. |
| examples/basic-order-processing-client/tsconfig.json | Switched example client TS config to extend @btravstack/tsconfig. |
| examples/basic-order-processing-client/package.json | Replaced local tsconfig devDep with @btravstack/tsconfig. |
| docs/package.json | Removed local tsconfig devDep from docs workspace (no longer needed). |
| .changeset/consume-btravstack-config.md | Added changeset to bump the fixed published group for config-source/devDep change. |
| .changeset/config.json | Updated ignore list to exclude private examples/docs/tests from Changesets. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #590 (shared-config adoption). Removes the local
tools/tsconfig&tools/typedocpackages entirely and points every consumer directly at the published@btravstack/tsconfig/@btravstack/typedocvia the catalog.tools/*; droptools/*from workspace globs@btravstack/{tsconfig,typedoc}/base.json;workspace:*→catalog:Gate green: changeset, typecheck, build, lint, format, knip, audit, test.