Repository navigation
Use dedicated ECR role for Helm releases - #107
Closed
Kevin Green (KevinGreen) wants to merge 1 commit into
Closed
Kevin Green (KevinGreen) wants to merge 1 commit into
Kevin Green (KevinGreen) wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the dedicated
github-helm-releaserole for chart publication instead of theAWS_ROLE_ARNsecret that points to the shared role. The new role grants only ECR Public authentication and chart upload access tohelm/braintrust, and trusts this repo onmain.Deploy the role from https://github.com/braintrustdata/infra/pull/506 before merging this workflow change. Releases must be dispatched from
main.Validation: diff checks passed; the release workflow has not been run.