Repository navigation
fix(ragas): score 0 when AnswerCorrectness classification is empty - #245
Open
Yuriy H (jurayh) wants to merge 1 commit into
Open
Yuriy H (jurayh) wants to merge 1 commit into
Yuriy H (jurayh) wants to merge 1 commit into
Conversation
compute_f1_score divided tp by tp + 0.5 * (fp + fn) unguarded. When the judge classifies nothing (empty TP, FP, and FN), Python raised ZeroDivisionError and TypeScript returned NaN, which serializes to null and reads as a skipped score. Return 0 when the denominator is 0, matching the guard in ContextRecall. Adds regression tests in both ports.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnswerCorrectnesscomputes its factuality F1 astp / (tp + 0.5 * (fp + fn))with no guard. When the judge classifies nothing, returning empty TP, FP, and FN lists, the denominator is 0. Python raisesZeroDivisionErrorand aborts the eval. TypeScript returns NaN, which serializes to null and reads as a skipped score.An empty classification is reachable in practice. It only takes an answer with no checkable claims, like a refusal, or a judge response with all three buckets empty.
This returns 0 when the denominator is 0, in both ports. That matches the existing guard in
ContextRecallin the same file, which scores 0 when there are no statements to attribute. Regression tests cover the empty case in Python and TypeScript, with the normal cases unchanged.No existing issue for this one. Happy to file one first if you prefer.