Skip to content

harden: add path validation in sync_datasets.ts #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anupam Mediratta (anupamme) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

harden: add path validation in sync_datasets.ts #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion evals/src/sync_datasets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,11 @@ async function coqaClosedQA(): Promise<ClosedQACase[]> {
}

function saveFile(cases: unknown[], fname: string) {
fs.writeFileSync(path.join(dataDir, fname), JSON.stringify(cases, null, 2));
if (!/^[\w-]+\.json$/.test(fname)) {
throw new Error(`Invalid output file name: ${fname}`);
}
const outPath = `${dataDir}${path.sep}${fname}`;
fs.writeFileSync(outPath, JSON.stringify(cases, null, 2));
}

async function main() {
Expand Down