install: Skip discoverable-partitions config for FCOS builds#2164
install: Skip discoverable-partitions config for FCOS builds#2164cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Conversation
Currently Fedora CoreOS derivatives don't yet work with systemd-gpt-auto-generator, see coreos/fedora-coreos-tracker#2137 It was briefly in an image which let our CI change to depend on it pass. Fix this by passing the existing `SKIP_CONFIGS` variable into the coreos image build. Closes: bootc-dev#2160 Assisted-by: OpenCode (Claude Opus 4) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a SKIP_CONFIGS build argument to the Dockerfile and the install-rpm-and-setup script, allowing the omission of the 20-discoverable-partitions.toml configuration. This is intended for environments like CoreOS that manage their own partitioning. Feedback indicates that this change will cause failures in the 052-test-bli-detection.nu integration test on Fedora 43+ systems, and it is recommended to update the test to account for this new behavior.
| cat > /usr/lib/bootc/install/20-discoverable-partitions.toml <<'EOF' | ||
| # Skip this when SKIP_CONFIGS is set (e.g. for CoreOS testing, where the | ||
| # target system uses its own partitioning scheme without DPS type GUIDs). | ||
| if [ -z "${SKIP_CONFIGS:-}" ]; then |
There was a problem hiding this comment.
Skipping the creation of 20-discoverable-partitions.toml when SKIP_CONFIGS is set will cause the integration test tmt/tests/booted/readonly/052-test-bli-detection.nu to fail on Fedora 43+ images (including CoreOS derivatives). That test explicitly asserts the absence of root= in the kernel command line, which depends on this configuration being present. You should consider updating the test (e.g., by checking VARIANT_ID) to skip that specific assertion when SKIP_CONFIGS is used or when running on CoreOS.
Pull request was converted to draft
|
OK this is related, but not the real bug. |
1 participant
Currently Fedora CoreOS derivatives don't yet work with systemd-gpt-auto-generator, see coreos/fedora-coreos-tracker#2137
It was briefly in an image which let our CI change to depend on it pass.
Fix this by passing the existing
SKIP_CONFIGSvariable into the coreos image build.Closes: #2160
Assisted-by: OpenCode (Claude Opus 4)