Skip to content

cli: Handle PermissionDenied when reading /proc/1/ns/ipc #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgwalters merged 1 commit into from
Apr 27, 2026
Merged

cli: Handle PermissionDenied when reading /proc/1/ns/ipc #2162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions crates/lib/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1595,6 +1595,9 @@ async fn usroverlay(access_mode: FilesystemOverlayAccessMode) -> Result<()> {
///
/// Requires `CAP_SYS_ADMIN` (needed for `setns()`); silently skipped when
/// running unprivileged (e.g. during RPM build for manpage generation).
/// Also skipped when `/proc/1/ns/ipc` is not accessible, which can happen
/// in restricted build environments (e.g. Tekton/Buildah containers) where
/// `/proc` is masked even for processes with `CAP_SYS_ADMIN`.
fn join_host_ipc_namespace() -> Result<()> {
let caps = rustix::thread::capabilities(None).context("capget")?;
if !caps
Expand All @@ -1603,7 +1606,13 @@ fn join_host_ipc_namespace() -> Result<()> {
{
return Ok(());
}
let ns_pid1 = std::fs::read_link("/proc/1/ns/ipc").context("reading /proc/1/ns/ipc")?;
let ns_pid1 = match std::fs::read_link("/proc/1/ns/ipc") {
Ok(v) => v,
Err(e) if e.kind() == std::io::ErrorKind::PermissionDenied => {
return Ok(());
}
Err(e) => return Err(e).context("reading /proc/1/ns/ipc"),
Comment thread
jmarrero marked this conversation as resolved.
};
let ns_self = std::fs::read_link("/proc/self/ns/ipc").context("reading /proc/self/ns/ipc")?;
if ns_pid1 != ns_self {
let pid1ipcns = std::fs::File::open("/proc/1/ns/ipc").context("open pid1 ipcns")?;
Expand All @@ -1612,7 +1621,6 @@ fn join_host_ipc_namespace() -> Result<()> {
Some(rustix::thread::LinkNameSpaceType::InterProcessCommunication),
)
.context("setns(ipc)")?;
tracing::debug!("Joined pid1 IPC namespace");
}
Ok(())
}
Expand Down