Skip to content

Add helm release and release 0.2.0 - #223

Merged
alicefr merged 5 commits into
mainfrom
add-helm-release
Oct 6, 2026
Merged

alicefr merged 5 commits into
mainfrom
add-helm-release

Conversation

@alicefr

@alicefr alicefr commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Create the release 0.2.0 in order to publish the helm chart

Fixes: #222

The generated service accounts, role bindings, and workload templates
were missing standard Helm labels (helm.sh/chart, managed-by, instance,
version). This caused conflicts when installing the chart into a cluster
with pre-existing kustomize-managed resources.

Assisted-by: AI
Signed-off-by: Alice Frosi <afrosi@redhat.com>
Run make helm to generate the helm chart, replace the version and tag
from the release and push the charts as oci artifact.

Assisted-by: AI
Signed-off-by: Alice Frosi <afrosi@redhat.com>
Assisted-by: AI
Signed-off-by: Alice Frosi <afrosi@redhat.com>
Signed-off-by: Alice Frosi <afrosi@redhat.com>
@alicefr alicefr changed the title Add helm release Add helm release and release 0.2.0 Oct 6, 2026
@alicefr alicefr added the release Label to trigger the release label Oct 6, 2026
@alicefr
alicefr marked this pull request as draft October 6, 2026 07:35
Assisted-by: AI
Signed-off-by: Alice Frosi <afrosi@redhat.com>
@alicefr
alicefr marked this pull request as ready for review October 6, 2026 08:12
Comment thread VERSION
@@ -1 +1 @@
0.1.0
0.2.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk why is this showing 0.1.0 but we were on 0.1.1

@alicefr alicefr Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we did the bump of the version in the release-0.1 branch only. It was a minor release

@alicefr alicefr Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release branches will start to diverge

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would only have the major release bumps

@redhat-chai-bot

Copy link
Copy Markdown

Review Findings

🔴 Blocking

del(.metadata.labels) in hack/sync-helm.sh silently drops all source labels, not just managed-by.

The old code only removed app.kubernetes.io/managed-by, preserving every other label the kustomize manifests carry (e.g. app.kubernetes.io/name, app.kubernetes.io/component, custom labels). The new code nukes the entire .metadata.labels map and replaces it solely with the Helm bootc-operator.labels template output. If the upstream kustomize manifests carry labels that aren't reproduced by that Helm helper, they'll be silently dropped in the generated chart.

Suggestion: Verify that bootc-operator.labels in _helpers.tpl covers everything the source manifests provide, or switch to a targeted delete-then-set approach that preserves labels the helper doesn't re-add.

Affected sites: gen_workload(), gen_binding(), gen_sa().


🟡 Non-blocking suggestions

  1. Release branch is created before artifacts are built and published. The Create release branch step runs immediately after tagging but before Set up Go, Build release manifest, and Package and push Helm chart. If any downstream step fails, you'll have a release branch (and tag) with no corresponding release or Helm chart. Consider moving branch creation after artifact publishing, or adding cleanup on failure.

  2. Placeholder sed is duplicated three times. The expression -e '/HELM_LABELS_PLACEHOLDER/c\ {{- include "bootc-operator.labels" . | nindent 4 }}' is copy-pasted into gen_workload(), gen_binding(), and gen_sa(). Extracting it into a shell variable or small helper function would reduce maintenance risk if the template name or nindent depth changes later.


Review generated with AI assistance — please verify for accuracy.


AI-generated. Review for accuracy.

@alicefr
alicefr merged commit 859e7bf into main Oct 6, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Label to trigger the release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add helm chart to the release process

3 participants