Add early dependency checks and fix packaging#252
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces bubblewrap as a mandatory dependency by updating the RPM spec file, the installation documentation, and the runtime binary validation logic. It also refines the documentation for existing prerequisites and adds explanatory comments regarding binary requirements. Review feedback recommends making the objcopy check conditional to prevent unnecessary dependencies for non-UKI images and suggests including qemu-img in the documentation to align with the package specifications.
0f38d7d to
2aa37f0
Compare
| ExclusiveArch: x86_64 aarch64 | ||
|
|
||
| Requires: binutils | ||
| Requires: bubblewrap |
There was a problem hiding this comment.
I think this is a dependency in the target system, not the host.
Not going to really hurt to require it on the host, but the original issue in #250 seems to mostly be about requirements in the target container.
So here and elsewhere, we should be clear about which component is required where.
And yes, the architecture is quite tricky with bubblewrap here, so I may be wrong.
There was a problem hiding this comment.
You're right. I had the dependency location backwards. The architecture is tricky: we run podman run , and the target image's entrypoint.sh uses bwrap, then run_impl() inside that namespace uses systemctl/objcopy.
Updated now: So the spec now only has true host requirements (podman, qemu-kvm, virtiofsd, openssh-clients for libvirt SSH), and docs clearly separate the two contexts to address the #250 confusion.
c61ba71 to
56e0ce5
Compare
Signed-off-by: gursewak1997 <gursmangat@gmail.com>
Closes: #250