Skip to content

Naming fixes in HarpoS7#20

Merged
bonk-dev merged 2 commits into
bonk-dev:mainfrom
jogibear9988:main
Jun 26, 2026
Merged

Naming fixes in HarpoS7#20
bonk-dev merged 2 commits into
bonk-dev:mainfrom
jogibear9988:main

Conversation

@jogibear9988

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.43%. Comparing base (af9e165) to head (560eb04).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
HarpoS7.Utilities/Auth/SiemensCsiKeyFlags.cs 87.50% 1 Missing and 1 partial ⚠️
HarpoS7.Utilities/Auth/BlobMetadataWriter.cs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files          68       69    +1     
  Lines       57985    58001   +16     
  Branches      301      303    +2     
=======================================
+ Hits        57076    57096   +20     
+ Misses        754      751    -3     
+ Partials      155      154    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jogibear9988 jogibear9988 mentioned this pull request Jun 22, 2026
@bonk-dev

Copy link
Copy Markdown
Owner

Codecov Report

❌ Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review. ✅ Project coverage is 98.43%. Comparing base (af9e165) to head (560eb04). ⚠️ Report is 4 commits behind head on main.
Files with missing lines Patch % Lines
HarpoS7.Utilities/Auth/SiemensCsiKeyFlags.cs 87.50% 1 Missing and 1 partial ⚠️
HarpoS7.Utilities/Auth/BlobMetadataWriter.cs 90.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Harness. 📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:

this is fine lmao dont bother adding these tests, I might add them myself later

@bonk-dev bonk-dev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bonk-dev bonk-dev merged commit 0afc118 into bonk-dev:main Jun 26, 2026
2 of 3 checks passed
@jogibear9988

Copy link
Copy Markdown
Contributor Author

Can you also create a new nuget?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants