Skip to content

shelley: use VM's current emoji for favicon - #251

Open
skybrian wants to merge 1 commit into
boldsoftware:mainfrom
skybrian:favicon-reflection-emoji
Open

shelley: use VM's current emoji for favicon#251
skybrian wants to merge 1 commit into
boldsoftware:mainfrom
skybrian:favicon-reflection-emoji

Conversation

@skybrian

@skybrian skybrian commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

We modified the server-side favicon generator to poll the integration URL for the emoji that's currently set for the VM. When the user changes the VM's emoji, it will usually change in Shelley on page reload.

Usually because we also added a cache with a one-minute timeout to avoid spamming the integration URL with requests. So, if you change the VM's emoji twice in a row, it won't change immediately the second time. The timeout was arbitrarily chosen and feels a bit long from the user's perspective; maybe it should be shorter?

Other nits: Shelley's favicon is full color and the VM page's emoji is not. I could fix it, but I like color so thought I'd ask first. Also, the way emojis render is inherently font- and platform-dependent.

@cla-bot

cla-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: exe.dev user.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Co-authored-by: Shelley <shelley@exe.dev>
@cla-bot cla-bot Bot added the cla-signed label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant