shelley: use VM's current emoji for favicon - #251
Open
skybrian wants to merge 1 commit into
Open
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: exe.dev user.
|
Co-authored-by: Shelley <shelley@exe.dev>
exe-dev-github-integration
Bot
force-pushed
the
favicon-reflection-emoji
branch
from
August 7, 2026 05:29
a2ba0a6 to
451a7b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We modified the server-side favicon generator to poll the integration URL for the emoji that's currently set for the VM. When the user changes the VM's emoji, it will usually change in Shelley on page reload.
Usually because we also added a cache with a one-minute timeout to avoid spamming the integration URL with requests. So, if you change the VM's emoji twice in a row, it won't change immediately the second time. The timeout was arbitrarily chosen and feels a bit long from the user's perspective; maybe it should be shorter?
Other nits: Shelley's favicon is full color and the VM page's emoji is not. I could fix it, but I like color so thought I'd ask first. Also, the way emojis render is inherently font- and platform-dependent.