Add Hover Icon Indicator to Storage#319
Open
mikhailmikhalchuk wants to merge 3 commits into
Open
Conversation
Indicates ability to place item in storage
No longer displays if pressing shift-click would do nothing Displays correctly for magic storage
Ensure non-blocking
Collaborator
|
A code injection was added a while back to make holding the keybind for "quick deposit to chest" (Left Shift / Left Control) change the trash icon to the chest icon when the Storage and Crafting UIs are open. |
Author
|
It did not at the time I made the change. I just tested again and it does not appear to change the icon when holding the quick deposit button on the keyboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the little "chest insert" icon to Magic Storage items, to indicate whether or not item can be placed in the storage. Currently, there is no method to indicate this and the cursor does not change at all. This commit changes the cursor so that it displays the icon when shift-clicking the item would place the item in storage or take it out, and keeps it normal when shift-clicking would do nothing (no space in inventory, in storage, etc.)