Tag Proto Fleet PR-eligible E2E scenarios - #883
Conversation
🔐 Codex Security Review
Review SummaryOverall Risk: NONE FindingsNo findings. NotesThe changed workflows parse successfully, and the PR detector identifies 35 spec files containing 61 Generated by Codex Security Review | |
There was a problem hiding this comment.
🟢 Ready to approve
The changes are limited to scenario title tagging/formatting and do not alter test behavior or shared helpers.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR updates the Proto Fleet Playwright E2E suite by appending @pr to selected scenario titles so they can be included in a future default PR-focused test subset without changing test logic or product behavior.
Changes:
- Appended
@prto selected Playwrighttest(...)titles across Proto Fleet E2E spec files. - Applied minor formatting (multi-line argument destructuring) where needed after title updates.
File summaries
| File | Description |
|---|---|
| client/e2eTests/protoFleet/spec/teamAccounts.spec.ts | Tag selected Team Accounts scenarios with @pr. |
| client/e2eTests/protoFleet/spec/sitesDetail.spec.ts | Tag the primary Site detail scenario with @pr. |
| client/e2eTests/protoFleet/spec/singleMinerView.spec.ts | Tag key fleet-hosted single-miner navigation scenarios with @pr. |
| client/e2eTests/protoFleet/spec/serverLogs.spec.ts | Tag Server Logs happy-path and error-path scenarios with @pr. |
| client/e2eTests/protoFleet/spec/securitySettings.spec.ts | Tag the admin credential update scenario with @pr (plus formatting). |
| client/e2eTests/protoFleet/spec/schedulesSettings.spec.ts | Tag schedule CRUD and validation scenarios with @pr. |
| client/e2eTests/protoFleet/spec/rbacMiners.spec.ts | Tag representative miner RBAC scenarios with @pr. |
| client/e2eTests/protoFleet/spec/rbacAdmin.spec.ts | Tag representative admin RBAC scenarios with @pr (plus formatting). |
| client/e2eTests/protoFleet/spec/rbac.spec.ts | Tag representative RBAC scenarios with @pr. |
| client/e2eTests/protoFleet/spec/racksOverviewActions.spec.ts | Tag rack overview action scenarios with @pr (plus formatting). |
| client/e2eTests/protoFleet/spec/racksManualAssignment.spec.ts | Tag manual rack assignment scenario with @pr (plus formatting). |
| client/e2eTests/protoFleet/spec/racksManagement.spec.ts | Tag racks management scenario with @pr. |
| client/e2eTests/protoFleet/spec/racksCreation.spec.ts | Tag rack creation/numbering scenarios with @pr. |
| client/e2eTests/protoFleet/spec/minersSleepWake.spec.ts | Tag miner sleep/wake scenarios with @pr. |
| client/e2eTests/protoFleet/spec/minersSettingsActions.spec.ts | Tag miner settings action scenarios with @pr. |
| client/e2eTests/protoFleet/spec/minersRename.spec.ts | Tag representative rename scenarios with @pr. |
| client/e2eTests/protoFleet/spec/minersFiltersViews.spec.ts | Tag filters + saved-views scenarios with @pr (plus formatting). |
| client/e2eTests/protoFleet/spec/minersAddRemove.spec.ts | Tag unpair/add single miner scenario with @pr. |
| client/e2eTests/protoFleet/spec/minersActions.spec.ts | Tag representative miners action scenarios with @pr. |
| client/e2eTests/protoFleet/spec/minerIssues.spec.ts | Tag miner issues scenario with @pr. |
| client/e2eTests/protoFleet/spec/groups.spec.ts | Tag representative groups scenarios with @pr. |
| client/e2eTests/protoFleet/spec/generalSettings.spec.ts | Tag general settings scenarios with @pr. |
| client/e2eTests/protoFleet/spec/fleetSavedViews.spec.ts | Tag fleet saved view scenario with @pr. |
| client/e2eTests/protoFleet/spec/fleetFilters.spec.ts | Tag fleet filters scenarios with @pr. |
| client/e2eTests/protoFleet/spec/firmware.spec.ts | Tag firmware upload/update scenario with @pr. |
| client/e2eTests/protoFleet/spec/dashboard.spec.ts | Tag dashboard shell render scenario with @pr. |
| client/e2eTests/protoFleet/spec/curtailmentSettings.spec.ts | Tag curtailment settings scenario with @pr. |
| client/e2eTests/protoFleet/spec/curtailment.spec.ts | Tag whole-fleet curtailment scenario with @pr. |
| client/e2eTests/protoFleet/spec/buildings.spec.ts | Tag representative buildings scenarios with @pr. |
| client/e2eTests/protoFleet/spec/buildingDetail.spec.ts | Tag building detail scenario with @pr. |
| client/e2eTests/protoFleet/spec/auth.spec.ts | Tag admin sign-in scenario with @pr. |
| client/e2eTests/protoFleet/spec/apiKeysSettings.spec.ts | Tag API key create/revoke scenario with @pr. |
| client/e2eTests/protoFleet/spec/addMinersValidation.spec.ts | Tag add-miners validation scenarios with @pr. |
| client/e2eTests/protoFleet/spec/activityLogin.spec.ts | Tag activity login audit scenario with @pr. |
| client/e2eTests/protoFleet/spec/activity.spec.ts | Tag representative activity scenarios with @pr. |
Review details
- Files reviewed: 35/35 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a87d65348
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
56b343b to
b4c2626
Compare
Reviewable diff: +0/-0 across 0 files (excludes generated, test, and story files).
Summary
This PR marks the Proto Fleet Playwright scenarios we want included in the default pull-request subset by appending
@prto their test titles. It does not change product behavior or test logic; it only labels a representative slice of the existing suite so we can wire PR-vs-nightly selection around explicit tags and see how that shape behaves in CI.How it works
Each selected scenario keeps its existing flow and assertions, but its title now includes
@pr. The tagged set covers 61 of the 130 non-setup, non-visual Proto Fleet scenarios, which keeps broad feature coverage while trimming the default PR set down to roughly the 1/3-to-1/2 range we discussed.Diagrams
Areas of the code involved
client/e2eTests/protoFleet/spec/**@prsuffixes to selected test titles across the Proto Fleet E2E specs.Key technical decisions & trade-offs
Testing & validation
./node_modules/.bin/eslinton the touched Proto Fleet spec filesclient-typecheckpassed when the branch was pushed