fix: private gomod approach needs updating for mirror clones#148
Open
fix: private gomod approach needs updating for mirror clones#148
Conversation
alecthomas
reviewed
Feb 24, 2026
|
|
||
| // Local clone from the mirror — git hardlinks objects by default. | ||
| // #nosec G204 - repo.Path() and cloneDir are controlled by us | ||
| cmd := exec.CommandContext(ctx, "git", "clone", repo.Path(), cloneDir) |
Collaborator
There was a problem hiding this comment.
Wouldn't it be better to do git clone --branch ... ?
Collaborator
Author
There was a problem hiding this comment.
Almost certainly yes, I will fix that.
alecthomas
reviewed
Feb 24, 2026
| @@ -284,21 +288,35 @@ func (p *privateFetcher) generateMod(ctx context.Context, repo *gitclone.Reposit | |||
| } | |||
|
|
|||
| func (p *privateFetcher) generateZip(ctx context.Context, repo *gitclone.Repository, modulePath, version string) (io.ReadSeekCloser, error) { | |||
Collaborator
There was a problem hiding this comment.
I don't recall when this is run, is it only if we don't already have a zip in the cache for the given version?
Collaborator
Author
There was a problem hiding this comment.
Yep, at least that's what I recall I did. I'll double check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the private go-mod fetcher to work with mirror clones. Additionally swaps from shelling out to create the zip to use https://pkg.go.dev/golang.org/x/mod/zip instead
Why?
The existing behaviour does not work with the new mirror clone approach.