-
Notifications
You must be signed in to change notification settings - Fork 3
feat(sandbox): add fork() and snapshot() helpers to SandboxInstance #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
drappier-charles
merged 2 commits into
main
from
cdrappier/devin/sandbox-fork-snapshot-helpers
Jul 24, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 New sandbox fork/snapshot feature ships without required integration tests
The new fork/snapshot capability is added with only mocked unit tests (
tests/core/test_sandbox.py:839-945) and no integration test exercising it against the real API, which AGENTS.md requires for every feature.Impact: The feature is merged without any real-API test coverage, so real endpoint regressions can go undetected.
Why this violates the repository rule
AGENTS.md states under Testing: "Every feature must ship with an integration test exercising it against the real API". Existing sandbox features each have an integration test under
tests/integration/core/sandbox/(e.g.test_sandbox_crud.py,test_lifecycle.py). The newfork(),snapshot(),list_snapshots(), anddelete_snapshot()methods added insrc/blaxel/core/sandbox/default/sandbox.pyandsrc/blaxel/core/sandbox/sync/sandbox.pyonly receive mocked unit tests intests/core/test_sandbox.py; a grep oftests/integration/core/sandbox/finds no fork/snapshot integration test (the only matches concern the unrelatedsnapshot_enabledconfig).Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.