fix: support conditional UM algo order types without breaking compatibility - #95
Closed
techleadevelopers wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi @techleadevelopers, thanks for bringing this up. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
NewUmAlgoOrderTypeEnumto support the conditional algo order types actually accepted by the Binance API for portfolio margin UM algo orders, while preserving backwards compatibility.Changes
LIMITandMARKETvariantsStopStopMarketTakeProfitTakeProfitMarketTrailingStopMarketas_str()mappingsFromStrmappingsWhy
The Binance API accepts the following conditional algo order types for these orders:
STOPSTOP_MARKETTAKE_PROFITTAKE_PROFIT_MARKETTRAILING_STOP_MARKETUsing
LIMITorMARKETfor these conditional algo orders results in-1130.This patch fixes the enum without introducing a breaking change for existing SDK users.
Compatibility
LIMITandMARKETare intentionally preserved and marked as deprecated:Notes
This is intentionally narrower than replacing the old variants outright. The goal is to correct API behavior while maintaining source compatibility for downstream users.
Related: #94
This patch takes the same issue in a backwards-compatible direction by preserving the old variants as deprecated instead of removing them.