Skip to content

Add expression interpreter#71

Draft
ubdbra001 wants to merge 2 commits intobids-standard:mainfrom
ubdbra001:i48-add-espression-interpreter
Draft

Add expression interpreter#71
ubdbra001 wants to merge 2 commits intobids-standard:mainfrom
ubdbra001:i48-add-espression-interpreter

Conversation

@ubdbra001
Copy link
Collaborator

Here's the initial attempt at adding all the parts of the expression language interpreter.

These successfully cover the full range of tests in the bidsschematools expression tests.
Two things that still need addressing:

  • exists passes the tests but needs more work to actually work as described in the schema tools docs
  • I'm not sure yet how to integrate them with the Context

@ubdbra001 ubdbra001 requested a review from effigies March 10, 2026 22:51
@ubdbra001 ubdbra001 self-assigned this Mar 10, 2026
@ubdbra001 ubdbra001 force-pushed the i48-add-espression-interpreter branch from 4229095 to 19cdfd0 Compare March 11, 2026 09:59
@ubdbra001 ubdbra001 force-pushed the i48-add-espression-interpreter branch from 19cdfd0 to 5bda559 Compare March 11, 2026 10:06
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 25.50336% with 111 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.68%. Comparing base (878d57d) to head (ca15030).

❌ Your patch check has failed because the patch coverage (25.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (77.68%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (878d57d) and HEAD (ca15030). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (878d57d) HEAD (ca15030)
16 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #71       +/-   ##
===========================================
- Coverage   90.89%   77.68%   -13.21%     
===========================================
  Files          13       14        +1     
  Lines         846      995      +149     
  Branches      124      167       +43     
===========================================
+ Hits          769      773        +4     
- Misses         47      194      +147     
+ Partials       30       28        -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant