Add Codecov configuration for PR coverage reporting#67
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
===========================================
+ Coverage 76.83% 90.89% +14.06%
===========================================
Files 13 13
Lines 846 846
Branches 124 124
===========================================
+ Hits 650 769 +119
+ Misses 169 47 -122
- Partials 27 30 +3 🚀 New features to boost your workflow:
|
pyproject.toml
Outdated
| omit = [ | ||
| "setup.py", | ||
| "*/_version.py", | ||
| "*/test_bids_validator.py", |
There was a problem hiding this comment.
I think it already is, at least as far as pytest is concerned at line 65:
[tool.pytest.ini_options]
minversion = "6"
testpaths = ["tests"] # <~~~~~~~~~~~ here
log_level = "INFO"
xfail_strict = true
addopts = ["-ra", "--strict-config", "--strict-markers"]
filterwarnings = ["error"]
norecursedirs = ["data"]
doctest_optionflags = ["NORMALIZE_WHITESPACE", "IGNORE_EXCEPTION_DETAIL"]So we should either move the test or update toml to point to it no?
There was a problem hiding this comment.
Yes, we should do either of those. I don't care which.
This actually demonstrates why I prefer to check coverage of test files, as it showed that it wasn't being run. So let's run it, rather than hide it.
bendhouseart
left a comment
There was a problem hiding this comment.
I'm pretty sure the tests are going to fail once these changes are added, but that aside I think these changes would make it good to go.
f7079b5 to
05317fe
Compare
|
I can't reproduce these errors locally. Except the one with |
Configures coverage status checks (project and patch) and PR comments so coverage impact is visible directly on pull requests.
This file is a legacy test in the source tree that requires datalad datasets at import time and is never executed as part of the test suite. Excluding it gives a more accurate coverage measurement.
05317fe to
982a6ca
Compare
Summary
codecov.ymlto configure coverage status checks and PR commentstest_bids_validator.pyfrom coverage reporting (broken imports, never runs as part of test suite)Test plan