Repository navigation
fix: add --no-error-on-unmatched-pattern to lint-staged commands - #49
Merged
Merged
Conversation
Prevents commit failures when the only staged JS/TS/etc file matched by the lint-staged glob is one oxfmt/oxlint ignores (e.g. generated files like routeTree.gen.ts). Refs #48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-error-on-unmatched-patternto theoxfmtandoxlint --fixinvocations in thelint-stagedblock ofpackage.json, matching the pattern used in material-fidelity / material-fidelity-avif.Why
When the only staged file matching a lint-staged glob is one that oxfmt/oxlint ignores (e.g. a generated file like
routeTree.gen.ts), both tools see zero matched files after applying their ignore rules and exit non-zero, failing the commit even though nothing is wrong.Closes #48
Test plan
oxfmt --no-error-on-unmatched-patternsuccessfully on this branch's own commit