Repository navigation
Fix empty Model Default selections in training configs - #3310
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a WebUI config with Auto-detect or Model Default selected can write empty strings for
prediction_type,validation_noise_scheduleranddistillation_method. Launching then emits flags such as--prediction_type=, which argparse rejects.Omit blank CLI values when a select offers a null choice and no explicit empty-string choice, allowing the parser to apply the model default. Preserve valid selections, intentionally empty negative prompts, and explicit empty resume choices. Existing saved configs work without manual editing.
Regression coverage includes prefixed/unprefixed keys, null/blank/whitespace values, explicit overrides, and repeated MOSS form normalization, save, JSON reload and real argparse parsing.
Validation: 85 configuration and training-service tests passed with Python 3.13: